View Single Post

  #2 (permalink)  
Old 24-04-2007, 11:27 PM
daviddoran's Avatar
daviddoran daviddoran is offline
Wannabe Geek
Recent Blog: iMSISS
 
Join Date: Aug 2006
Location: Meath, Ireland
Posts: 342
Nominated 0 Times in 0 Posts
TOTW/F/M Award(s): 0
daviddoran will become famous soon enough
Default

I'm just going to list some thoughts:
  1. "Please Remove Install.php should die not just echo.
  2. Remove XSS-able echo $_REQUEST['p'] in title
  3. SQL-attack possible through $_REQUEST['p'] (Must sanitize)
  4. Try and separate presentation from logic.
  5. Make templates for the admin area, so you can easily change layout.

I know it's all negative here but I just flicked through the code and I'm sure over-all it's very good.

(PS:Welcome to the forums, we can never have too many Davids)
Reply With Quote